Add mysqlclient dependency to address missing MySQLdb module#35507
Closed
shunping wants to merge 1 commit intoapache:masterfrom
Closed
Add mysqlclient dependency to address missing MySQLdb module#35507shunping wants to merge 1 commit intoapache:masterfrom
shunping wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Collaborator
Author
|
If adding the dialect (mentioned in #35501 (comment)) works, we don't need this PR. |
Collaborator
Author
|
Given that the failed test has passed again with the fix in #35501, I think we no longer need to add this dependency. Closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the following failed test in PR #35501
https://github.com/apache/beam/runs/45163445946, looks like we need to install this dependency